Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython 3.0 Breaks Kiva Build #1060

Open
corranwebster opened this issue Jul 21, 2023 · 2 comments
Open

Cython 3.0 Breaks Kiva Build #1060

corranwebster opened this issue Jul 21, 2023 · 2 comments

Comments

@corranwebster
Copy link
Contributor

We are seeing C++ errors in the Kiva build - incorrect wrapper code is somehow being generated. There look to be multiple different errors, so it may take a little time to unwind.

In the mean time, we may want to update the build requirements to specify earlier Cython.
@corranwebster corranwebster mentioned this issue Jul 21, 2023
Merged
corranwebster added a commit that referenced this issue Jul 21, 2023
@corranwebster
Insist on Cython prior to 3.0 (#1061)
84b611d 
Hopefully this is a quick-fix for #1060 - but a more permanent fix will be needed at some future point.

Now includes a work-around for #1062
@drbsg
Copy link

drbsg commented Jul 25, 2023

This is affecting v5.3.1 as well on platforms which do not have binary wheels available (in particular Windows). I would very much appreciate a back-port of a fix for this.

@corranwebster
Copy link
Contributor Author

The work-around in the short-term is to specify "cython<3" in the pyproject.toml before building. I'm not sure we have bandwidth to backport fixes in the near-term, but I will happily review PRs.

@corranwebster corranwebster mentioned this issue Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drbsg @corranwebster