Skip to content

Latest commit

 

History

History
88 lines (69 loc) · 3.47 KB

PeerReview-Exercise2.md

File metadata and controls

88 lines (69 loc) · 3.47 KB

Solution Assessment

Peer-reviewer Information

Stage 1

  • Perfect
  • Great
  • Good
  • Satisfactory
  • Unsatisfactory

Justification

The camera is always centered on the Vessel. The drawn cross meets the requirements.

Stage 2

  • Perfect
  • Great
  • Good
  • Satisfactory
  • Unsatisfactory

Justification

The camera is able to move on the z-x plane. The vessel will not move out of the frame. When the vessel is still, it can move at the same velocity as the camera. The frame is drawn correctly.

Stage 3

  • Perfect
  • Great
  • Good
  • Satisfactory
  • Unsatisfactory

Justification

The vessel will not move out of the leash distance. Both follow_speed and catchup_speed perform correctly. The frame is drawn correctly.

Stage 4

  • Perfect
  • Great
  • Good
  • Satisfactory
  • Unsatisfactory

Justification

The vessel will not move out of the leash distance. lead_speed, catchup_delay_duration, and catchup_speed meet the requirement individually.

One minor flaw is that when the vessel moves at HYPER_SPEED, the camera should lead the vessel rather than center on the vessel.

Stage 5

  • Perfect
  • Great
  • Good
  • Satisfactory
  • Unsatisfactory

Justification

The vessel is able to move in the direction of target's movement when the vessel touchs the outer box. The frame is drawn correctly.

When the vessel is still and in between the inner box and outer box, the camera should not move. However, in the student's work, the camera will move until the vessel is inside of the inner box. Moreover, when the vessel is in between the inner box and outer box, the camera will not move in the direction of the vessel's movement. There is a little gap that make the vessel cannot touch both inner and outer box.

Code Style

Overall, the code style is consistent

Style Guide Infractions

All the code files should be put in the camera_controllers folder instead of scenes folder

Style Guide Exemplars

  1. correct use of snake_case to name variable and function
  2. Use PascalCase for every class.

Best Practices

In general, the code needs more comments. Some places need time to understand without comments.

Best Practices Infractions

case 1, case 2 --Need comments for each if statement

Best Practices Exemplars