Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounts kwarg to AsyncClient is not documented in the docstring #3349

Open
samuelcolvin opened this issue Oct 17, 2024 · 2 comments
Open

mounts kwarg to AsyncClient is not documented in the docstring #3349

samuelcolvin opened this issue Oct 17, 2024 · 2 comments

Comments

@samuelcolvin
Copy link

See

httpx/httpx/_client.py

Line 641 in 1bf1fc0

mounts: None | (typing.Mapping[str, BaseTransport | None]) = None,

Both on main and v0.27.2 mounts is not documented in the docstring above, unlike other arguments.

🙏
@samuelcolvin
Copy link
Author

Also, perhaps related, the docs refer to httpx.Mounts, but that doesn't seem to exist.

@karpetrosyan
Copy link
Member

karpetrosyan commented Oct 17, 2024 •
edited
Loading

Good catch @samuelcolvin , thank you! We should probably revert #3081 for now.

@karpetrosyan karpetrosyan mentioned this issue Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samuelcolvin @karpetrosyan and others