Infinity reading #859
Unanswered
Anthonybelui
asked this question in
Potential Issue
Replies: 1 comment
-
Well spotted yea. A pull request for this would be ace. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello, thanks for developing the library.
I wanted to ask you to fix/define the logic for the read timeout in socks_proxy. This creates an infinity reading.
File httpcore/_sync/socks_proxy.py
Function _init_socks5_connection()
Line:
incoming_bytes = stream.read(max_bytes=4096)
>incoming_bytes = stream.read(max_bytes=4096, timeout=SomeTimeout)
Beta Was this translation helpful? Give feedback.
All reactions