Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

columnname injections could take over R session #4

Open
sorhawell opened this issue Nov 8, 2018 · 1 comment
Open

columnname injections could take over R session #4

sorhawell opened this issue Nov 8, 2018 · 1 comment

Comments

@sorhawell
Copy link
Contributor

sorhawell commented Nov 8, 2018

Reading through the code I found this in file:

  • in ShinyTreeMenu/R/ShinyTreeMenuHTML.R* treedata <- treedata[eval(parse(text = lookfor))]

I especially discourage use eval-parse in server-side / client-side interactions for security reasons. Client-side injections may be possible. Or at least maintainers have to consider this every time updating the code.

from library(fortunes)...

Thomas Lumley's fortune "If the answer is parse() you should usually rethink the question."

funny example of sql-injection
image

@emillykkejensen
Copy link
Owner

Might be something to take into account if doing a code revision - thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants