Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite incorrectly applied to cases where assetPath exists with arbitrary suffix #57

Open
robbytx opened this issue Jul 27, 2017 · 0 comments

Comments

@robbytx
Copy link

robbytx commented Jul 27, 2017

I've stumbled across an issue where:

  doSomething('myapp.js.something');

is replaced with:

  doSomething('myapp-48aceae9b10d78520352913b3085d74c.js.something');

It seems that rewriteAssetPath intentionally accepts and preserves any suffix that does not contain one of: " ' ( ) \ > =

Possibly there is some reason for this behavior, but I can't imagine what it is, especially since the query string is expected after this arbitrary suffix.

At the very least, it seems wrong to match additional path-like suffixes like:

  • myapp.js0
  • myapp.js_alt
  • myapp.js.other
  • myapp.js/subfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant