fix: perform segmentation accordign to ACL max #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
lulf
force-pushed
the
acl-segmentation
branch
from
de9e2a9 to
cfe2ffa
Compare
|
/test |
|
I have tested this branch for the conditions in issue #260 and I can confirm that the same issues are observed. |
hicklin
reviewed
Jan 27, 2025
lulf
force-pushed
the
acl-segmentation
branch
from
cfe2ffa to
a6e10aa
Compare
|
I've verified that it fixes the potential of missing ACL segmentation when using larger l2cap mtu on nrf, even if it doesn't seem to fix #260. |
|
/test |
Fix a bug where outbound l2cap packets would not get segmented according to ACL max for connection oriented channels.
lulf
force-pushed
the
acl-segmentation
branch
from
a6e10aa to
c246eea
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where outbound l2cap packets would not get segmented according to ACL max for connection oriented channels.
Might fix #260