Allow getting and setting all attributes #261
Draft
+134
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es beyond characteristics
…ting-all-attributes
…ng-and-setting-all-attributes
This reverts commit 2793596.
…ting-all-attributes
|
Do we need to assert that a writeable descriptor must also be named? |
I don't think so, because setting the descriptor as writeable only affects whether it can be written by a connected device. |
petekubiak
commented
Jan 30, 2025
| @@ -69,6 +69,7 @@ impl Primitive for f32 {} | |||
| impl Primitive for f64 {} | |||
| impl Primitive for BluetoothUuid16 {} // ok as this is just a NewType(u16) | |||
| impl Primitive for &'_ str {} | |||
| impl Primitive for &'_ [u8] {} | |||
There was a problem hiding this comment.
This impl follows the same flawed logic highlighted in #272 and will require the same fix (assuming I can find one 😅)
jamessizeland
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements generic get and set methods, allowing getting and setting of descriptors and characteristic properties.
This is a draft to get feedback on what you think of the implementation, I think some documentation and examples are needed before merging.
Resolves #155.