Skip to content

Developer guidelines

Edward L Platt edited this page Feb 20, 2014 · 7 revisions

Short summary

  • Talk to the dev-list or join the weekly hangout before implementing a change.
  • Submit changes as issue-specific pull requests against the dev branch.

Pull requests

  • To encourage code review, submit all changes as pull requests.
  • Pull requests should be from an issue-specific branch to the dev branch.
  • Pull requests should be reviewed and approved by someone other than the author.
  • Contributors should add themselves to the CONTRIBUTORS file.
  • All new features must be discussed on the dev list or weekly hangout before they are implemented.
  • "Out of the blue" pull requests will be rejected.

Coding standards

  • We follow Drupal Coding Standards.
  • We indent with spaces only, no tabs.
  • We use UNIX line endings.
  • If you are looking for a good editor that lets you control line endings and whitespace, try Komodo Edit.

Commit messages

  • Include issue numbers in commit messages.
  • Include a descriptive summary of 80 characters or less, ending with a period.
  • More details can go after the summary.
  • Example: "Adds javascript to focus elements with focus class, Closes #74."