Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project does not compile with nom 5 #32

Closed
kryptan opened this issue May 20, 2020 · 4 comments
Closed

Project does not compile with nom 5 #32

kryptan opened this issue May 20, 2020 · 4 comments
Assignees
Labels
bug dependencies Pull requests that update a dependency file help wanted

Comments

@kryptan
Copy link

kryptan commented May 20, 2020

Recent commit has updated nom from 4 to 5 but library does not compile with newer nom version.

@hexjelly hexjelly added bug dependencies Pull requests that update a dependency file labels May 21, 2020
@hexjelly
Copy link
Member

Yea it hasn't worked for a while, and never got around to looking into rewriting the code to work with the new version. It was a mistake to update the dependencies without fixing the error, alas.

@hexjelly hexjelly self-assigned this May 21, 2020
@hexjelly
Copy link
Member

It won't fix the problem you were having with the level since it's very much unrelated, but I'll try to see if I can fix whatever changes is needed with the new nom version.

@hexjelly
Copy link
Member

Couldn't easily find out how to refactor the nom related code, so for now I just reverted the old commit so master builds again.

Leaving issue open as updating to the new nom 5 API should probably be done at some point anyway. Maybe even look into doing it for the other modules as well where it's not used.

@hexjelly
Copy link
Member

hexjelly commented Nov 4, 2024

Fixed by #42

@hexjelly hexjelly closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file help wanted
Projects
None yet
Development

No branches or pull requests

2 participants