Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Distinct scopes for atoms and keywords #445

Open
pikeas opened this issue Dec 29, 2024 · 1 comment
Open

[Feature request] Distinct scopes for atoms and keywords #445

pikeas opened this issue Dec 29, 2024 · 1 comment

Comments

@pikeas
Copy link

pikeas commented Dec 29, 2024

Environment

  • Elixir 1.18.0 (compiled with Erlang/OTP 27)
  • MacOS VSCode, ElixirLS 0.25.0

Current behavior

Atoms and keyword lists have identical syntax highlighting.

Screenshot 2024-12-29 at 08 35 52

Inspect Editor Tokens and Scopes shows they both have a token type of constant.language.symbol.elixir.source.elixir.

Expected behavior

Different language constructs should have different scopes. For another example, true, false, and nil have the same scope as well.

@lukaszsamson
Copy link
Collaborator

It was like that since the first grammar. I won't risk any dramatic changes here. Maybe adding a subtype would be OK, but this would need a custom highlighting scheme

@lukaszsamson lukaszsamson changed the title More detailed language tokens [Feature request] Distinct scopes for atoms and keywords Dec 29, 2024
@lukaszsamson lukaszsamson transferred this issue from elixir-lsp/elixir-ls Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants