Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bottom actions button colors for themes #2075

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 27, 2025

Adjust colors for bottom action buttons to improve visibility and consistency across dark and light themes.

image

Copy link

github-actions bot commented Jan 27, 2025

@josevalim
Copy link
Member

Here is how it looks for Erlang, a bit weird I think:

Screenshot 2025-01-27 at 16 03 21

cc @garazdawi

@hichemfantar
Copy link
Contributor Author

I suppose the red border is the issue here

@josevalim
Copy link
Member

And here is the other option:

Screenshot 2025-01-27 at 16 05 52

I am thinking the current version strikes the best balance. The best way to think about it is that it is a button rather than a link.

@josevalim
Copy link
Member

@hichemfantar we could try one with the border in the same but that may be too different from the theme. Btw, you can generate the Erlang version with mix docs --proglang erlang.

@hichemfantar
Copy link
Contributor Author

i think it's good now

@josevalim
Copy link
Member

Here are the new versions.

Erlang

Screenshot 2025-01-27 at 16 41 59

Elixir

Screenshot 2025-01-27 at 16 42 31

I am fine with both current and this PR, so I am glad to listen to @garazdawi's and @DavidOliver's preferences too.

@hichemfantar
Copy link
Contributor Author

lgtm

@DavidOliver
Copy link
Contributor

LGTM, too, if we're not using red for Erlang's inner content links. I agree it's best to keep the red and blue away from each other in this case.

Thanks!

@garazdawi
Copy link
Contributor

I don’t have a preference, go with whichever you think works best.

@josevalim
Copy link
Member

@DavidOliver I know you said it looks good to you but do you prefer this one?

@DavidOliver
Copy link
Contributor

@josevalim, I prefer it to combining a red outline and blue link text. Is that what you mean?

@josevalim
Copy link
Member

If you prefer the one currently in main or this one. :)

@DavidOliver
Copy link
Contributor

@josevalim, sorry. 😄 I prefer this one, with the page title in the language colour.

@josevalim josevalim merged commit 0bf8b60 into elixir-lang:main Jan 27, 2025
3 of 4 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@hichemfantar hichemfantar deleted the better-pagi-link branch January 27, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants