From b0415566d82c7d67193c701c7c1966fa19eea23d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Wed, 29 May 2024 11:20:28 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Andrea Leopardi --- lib/ex_unit/lib/ex_unit/case.ex | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/ex_unit/lib/ex_unit/case.ex b/lib/ex_unit/lib/ex_unit/case.ex index 307541f2b05..6bc3930fa42 100644 --- a/lib/ex_unit/lib/ex_unit/case.ex +++ b/lib/ex_unit/lib/ex_unit/case.ex @@ -239,7 +239,7 @@ defmodule ExUnit.Case do For example, Elixir has a module called `Registry`, which can have type `:unique` or `:duplicate`, and can control its concurrency factor using the `:partitions` option. If you have a number of tests that *behave the - same* across all of those values, I can parameterize those tests with: + same* across all of those values, you can parameterize those tests with: setup_all do parameters = @@ -252,12 +252,12 @@ defmodule ExUnit.Case do Use parameterized tests with care: - * Abuse of parameterized tests may make your test suite considerably slower + * Abuse of parameterized tests may make your test suite considerably slower - * If you use parameterized tests and then find yourself adding conditionals - in your tests to deal with different parameters, then parameterized tests - may be the wrong solution to your problem. Consider creating separated - tests and sharing logic between them using regular functions + * If you use parameterized tests and then find yourself adding conditionals + in your tests to deal with different parameters, then parameterized tests + may be the wrong solution to your problem. Consider creating separated + tests and sharing logic between them using regular functions ## Log Capture