From abe316a20025f3f9da35f2bf5c433d930a124a19 Mon Sep 17 00:00:00 2001
From: Eli Pousson <eli.pousson@gmail.com>
Date: Fri, 28 Apr 2023 22:37:16 -0400
Subject: [PATCH] test: expand st_make_grid_ext tests + restore read_sf_ext
 tests

---
 tests/testthat/test-read_sf_ext.R      | 38 +++++++++++++-------------
 tests/testthat/test-st_make_grid_ext.R | 10 +++++++
 2 files changed, 29 insertions(+), 19 deletions(-)

diff --git a/tests/testthat/test-read_sf_ext.R b/tests/testthat/test-read_sf_ext.R
index 4a9651c..3dc3069 100644
--- a/tests/testthat/test-read_sf_ext.R
+++ b/tests/testthat/test-read_sf_ext.R
@@ -36,23 +36,23 @@ test_that("read_sf_ext works", {
   )
 
   # skip_if_offline("opendata.baltimorecity.gov/egis/rest/services/")
-  # expect_s3_class(
-  #   read_sf_ext(
-  #     url = "https://opendata.baltimorecity.gov/egis/rest/services/Hosted/311_Customer_Service_Requests_2020_csv/FeatureServer/0",
-  #     name = "Abell",
-  #     name_col = "neighborhood",
-  #     coords = c("longitude", "latitude")
-  #   ),
-  #   "sf"
-  # )
-  #
-  # expect_s3_class(
-  #   read_sf_ext(
-  #     url = "https://opendata.baltimorecity.gov/egis/rest/services/Hosted/311_Customer_Service_Requests_2020_csv/FeatureServer/0",
-  #     name = "Abell",
-  #     name_col = "neighborhood",
-  #     coords = NULL
-  #   ),
-  #   "data.frame"
-  # )
+  expect_s3_class(
+    read_sf_ext(
+      url = "https://opendata.baltimorecity.gov/egis/rest/services/Hosted/311_Customer_Service_Requests_2020_csv/FeatureServer/0",
+      name = "Abell",
+      name_col = "neighborhood",
+      coords = c("longitude", "latitude")
+    ),
+    "sf"
+  )
+
+  expect_s3_class(
+    read_sf_ext(
+      url = "https://opendata.baltimorecity.gov/egis/rest/services/Hosted/311_Customer_Service_Requests_2020_csv/FeatureServer/0",
+      name = "Abell",
+      name_col = "neighborhood",
+      coords = NULL
+    ),
+    "data.frame"
+  )
 })
diff --git a/tests/testthat/test-st_make_grid_ext.R b/tests/testthat/test-st_make_grid_ext.R
index 0b12fcf..bf8f9ee 100644
--- a/tests/testthat/test-st_make_grid_ext.R
+++ b/tests/testthat/test-st_make_grid_ext.R
@@ -5,6 +5,11 @@ test_that("st_make_grid_ext works", {
     "sf"
   )
 
+  expect_s3_class(
+    st_make_grid_ext(as_bbox(nc)),
+    "sf"
+  )
+
   expect_s3_class(
     st_make_grid_ext(nc, ncol = 4, nrow = 1),
     "sf"
@@ -19,4 +24,9 @@ test_that("st_make_grid_ext works", {
     st_make_grid_ext(nc, n = 10, style = "square"),
     "sf"
   )
+
+  expect_s3_class(
+    st_make_grid_ext(nc, n = 10, style = "circle"),
+    "sf"
+  )
 })