Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the math zoom feature #149

Open
pkra opened this issue Mar 11, 2016 · 2 comments
Open

removing the math zoom feature #149

pkra opened this issue Mar 11, 2016 · 2 comments

Comments

@pkra
Copy link
Contributor

pkra commented Mar 11, 2016

We re-implemented the zoom via MathJax at AmerMathSoc/AMS-Lens#29. This fixes several bugs and, philosophically, seems the better place to have it. But now we have two zooms and they can clash.

I would like to propose to remove the zoom feature from the math extension.

I'm happy to make the necessary changes but would like to hear if there's a chance it will get merged.

@pkra
Copy link
Contributor Author

pkra commented Mar 14, 2016

An alternative option / compromise might be to have a generic shrink/zoom feature, not just for math but for other elements (e.g., tables).

@pkra
Copy link
Contributor Author

pkra commented Apr 28, 2016

Just to make a note here. I've implemented a scale/zoom feature for AMS Lens. This could probably be made content agnostic (e.g., support all MathJax output, both server and client-side MathJax, other forms of HTML-math) if there's interest.

I'm unable to properly re-write Lens's formula-zoom extension though. I don't claim to understand the internal flow, but following the existing code, I could get most of the way -- except for the initial fitFormula call. IIUC the current code depends on the fact that MathJax's signal will come in after Lens is finished, but only because it is slower than Lens, i.e., it's basically a racing condition. Now that's not a problem with client-side MathJax but if that's not around, this won't work. I couldn't figure out if Lens has some signalling for being done with its rendering so I'm currently listening to the body class names which seems like a terrible idea. Is there a signaling method I missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant