Fix highlighting after reselection of same word #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sync with GitManager and ProjectChooserButton
|
@zeebok You may like to take a look at this and let me know if by any chance it also fixes the crashing problem we discussed. |
zeebok
previously approved these changes
Dec 1, 2024
|
@zeebok I see what you mean. I have now separated the throttle for the selection change signal so that can be faster. Could you reproduce the crash on |
jeremypw
dismissed
zeebok’s stale review
Significant changes made since review
Increase maximum length of selection for highlighting
…rtup Jeremypw/sync activeproject startup
jeremypw
force-pushed
the
jeremypw/rework-highlight-selection
branch
from
6816410 to
2a7161d
Compare
|
@jeremypw I will try to take a look at this review again this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1483
Throttling the update-spaces function was tried but the resulting lag was found to be distracting so now they are updated straight-away as before. This is inefficient but any improvement can be left for another PR.