Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading text on empty Pinned messages banner #28261

Open
domestomas opened this issue Oct 21, 2024 · 3 comments
Open

Misleading text on empty Pinned messages banner #28261

domestomas opened this issue Oct 21, 2024 · 3 comments
Labels
A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Product More input needed from the Product team

Comments

@domestomas
Copy link

domestomas commented Oct 21, 2024 •
edited
Loading

Steps to reproduce

  1. Open a pinned messages banner panel in a room where the list is empty and you have no right to pin messeges

Outcome

What did you expect?

To see something like "There are no pinned messages. You have no right to pin messages because..."

What happened instead?

The text is a bit misleading:
"Pin important messages so that they can be easily discovered
Select a message and choose “Pin” to it include here."

Application version

Element nightly 2024102001
@dosubot dosubot bot added A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 21, 2024
@MidhunSureshR MidhunSureshR added the S-Minor Impairs non-critical functionality or suitable workarounds exist label Nov 1, 2024
@florianduros
Copy link
Member

Why do you mean by Open a pinned messages banner in a room? The banner is displayed in a room without any user interaction when there is at least one pinned message.

@t3chguy
Copy link
Member

t3chguy commented Nov 19, 2024

Based on the rest of the issue sounds like they mean right panel instead of banner, that text is indeed there

@domestomas
Copy link
Author

Yes, sorry, it should be panel not banner.

@florianduros florianduros added the X-Needs-Product More input needed from the Product team label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Product More input needed from the Product team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@t3chguy @florianduros @MidhunSureshR @domestomas