Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Changed room avatar" notice in timeline has v-offset on thumbnail #26070

Closed
HarHarLinks opened this issue Aug 29, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12016
Closed

"Changed room avatar" notice in timeline has v-offset on thumbnail #26070

HarHarLinks opened this issue Aug 29, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12016
Labels
good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Z-Compound

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

  1. set room avatar

Outcome

What did you expect?

avatar is in line with text (vertically centered on the line)

What happened instead?

image

Operating system

arch

Browser information

firefox 116.0.3

URL for webapp

https://develop.element.io

Application version

Element version: fcd8052-react-64f762d7b0f3-js-5788d9744b76 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

No
@dbkr dbkr added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 7, 2023
@MidhunSureshR MidhunSureshR self-assigned this Sep 20, 2023
@Johennes Johennes added Help Wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ labels Nov 8, 2023
@lalitkumawat1m
Copy link

I want to work on this issue please assign it to me

@t3chguy
Copy link
Member

t3chguy commented Nov 16, 2023

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

@anoopw3bdev anoopw3bdev mentioned this issue Dec 8, 2023
Merged
3 tasks
@HarHarLinks HarHarLinks mentioned this issue Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Z-Compound
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix position of thumbnail in room timeline anoopw3bdev/matrix-react-sdk
7 participants
@dbkr @Johennes @t3chguy @HarHarLinks @MidhunSureshR @daniellekirkwood @lalitkumawat1m