fix: sea error handling #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
erickzhao
approved these changes
Feb 13, 2025
|
Seems good to me, good catch, thank you! |
|
Thank you both, @erickzhao and @felixrieseberg! 🙌 |
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throw new Error(error)does not terminate the SEA process when used via Forge'sMakerSquirrel.I had a case where due to a misconfiguration an error was thrown in the
tryblock and subsequently caught in thecatchblock that this PR modifies. The process didn't exit upon reachingthrow new Error(error). Instead, it kept running indefinitely. (This reproduced reliably every time I ran it.)As a result, my
electron-forge makecommand kept running indefinitely (without succeeding or failing) becausesquirrel.exe --releasifythought signing (via the SEA) was still ongoing.My guess is that it has something to do with stdout/stderr. If I log the error in the
catchblock usingconsole.logorconsole.error, the process also does not terminate.The issue was hard to debug. It took me ~4 hours to figure out. Hope this will save someone else from having to do the same.