Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shape configuration is out of date. #8

Open
thruflo opened this issue Jan 21, 2025 · 0 comments
Open

Shape configuration is out of date. #8

thruflo opened this issue Jan 21, 2025 · 0 comments

Comments

@thruflo
Copy link

thruflo commented Jan 21, 2025

https://github.com/electric-sql/electric_phoenix/blob/main/lib/electric/phoenix/gateway.ex#L13

Should put the shape definition params under a "params" key. If we want the config returned to be the format it can be passed to a ShapeStream directly as config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thruflo