From 867a92d987be15dbc3b12b2e8f7ec5352129690e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?IOhannes=20m=20zm=C3=B6lnig?= Date: Thu, 27 Aug 2020 15:04:56 +0200 Subject: [PATCH] use '==' instead of 'is' for testing rcode values seems like with newer pydns, the type (of at least dns.rcode.*) has changed to some enum, so the "is" comparision always evaulates to False. this in turn makes the script fail (as it wrongly believes that adding/deleting the TXT record failed) --- dehydrated-hook-ddns-tsig.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dehydrated-hook-ddns-tsig.py b/dehydrated-hook-ddns-tsig.py index e72a994..e175f98 100755 --- a/dehydrated-hook-ddns-tsig.py +++ b/dehydrated-hook-ddns-tsig.py @@ -266,7 +266,7 @@ def _do_create_txt(dn): logger.debug(" + Creating TXT record %s -> %s returned %s" % ( head, tail, dns.rcode.to_text(rcode))) - if rcode is dns.rcode.NOERROR: + if rcode == dns.rcode.NOERROR: return dn except DNSException as err: logger.debug("", exc_info=True) @@ -360,7 +360,7 @@ def _do_delete_txt(dn): logger.debug(" + Removing TXT record %s -> %s returned %s" % ( head, tail, dns.rcode.to_text(rcode))) - if rcode is dns.rcode.NOERROR: + if rcode == dns.rcode.NOERROR: return dn except DNSException as err: logger.debug("", exc_info=True)