Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad approach to retreive ip prefix AND no mention about src/config.json file in README.md #8

Open
bfrenan opened this issue Jan 16, 2025 · 1 comment

Comments

@bfrenan
Copy link

bfrenan commented Jan 16, 2025

First:
The way you get IP prefix in method find_LAN_prefix in Connection_monitors/AlivenessCheck.py is not the best because if you have 2 network interfaces with an IP configured, the command 'hostname -I | cut -d "." -f 1,2,3' will get only the first one IP (which in my case, my WNIC was the second IP in the output of hostname -I). And you dont even mention that this should be considered when deploying the scenario, so I think this is actually a bug.

Second:
I was having trouble trying to use the tool because, while discovering IP addresses before standard management frames fuzzing start, it always returned a bad MAC address that were not in my network (casually the IP was the same).
Reading the code I realized that "sta_IP" is obtained from ARP table by looking for the MAC address stored in "targeted_STA" (same for "targeted_AP"). As these variables are initialized in fuzz_init.py, it is read from src/config.json.
In src/readme.txt you mention that config.json shall be changed, but you do not mention it in README.md. It took me a while until I realized that, I only wanted to use the tool but not change the code... I think It would be nice for the users if you update your README.md

@efchatz
Copy link
Owner

efchatz commented Jan 17, 2025

Thank you for the suggestions. We will review them and we will provide a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants