Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version check to precheck #230

Open
jeffdi opened this issue Sep 14, 2023 · 7 comments
Open

add version check to precheck #230

jeffdi opened this issue Sep 14, 2023 · 7 comments
Assignees

Comments

@jeffdi
Copy link
Contributor

jeffdi commented Sep 14, 2023

Add check to precheck that would compare its version to a version tag posted in a known file location on the precheck git repo.

If the current version is behind, post a warning (minimally) with instructions on how to update (e.g. make precheck).

@jeffdi
Copy link
Contributor Author

jeffdi commented Sep 14, 2023

Perhaps this should be a hard failure.

@marwaneltoukhy
Copy link
Member

@jeffdi I think this check might be better to be implemented in the user project's makefile, as the makefile is responsible for the user's environment, and is aware of which tag the user is currently using.

We could print a warning that the precheck version is incorrect and exit, and provide the user with the target they can run to update precheck (which is make precheck)

@jeffdi
Copy link
Contributor Author

jeffdi commented Sep 19, 2023

@marwaneltoukhy i think that misses the objective. we want precheck to check its version against the current available. the point is not to lock in on a tag, but to enable us to roll out a new version and users will automatically be prompted to update the next time they run, regardless of the version of caravel_user_project they started their project with (which can be behind in many cases).

@jeffdi
Copy link
Contributor Author

jeffdi commented Sep 19, 2023

there is never a case where a user should be using an old version of precheck.

@jeffdi
Copy link
Contributor Author

jeffdi commented Jan 24, 2024

PR pending - still needs final review

@jeffdi
Copy link
Contributor Author

jeffdi commented Feb 28, 2024

create new version of user flow with the proposed changes in the PR.

@DavidRLindley
Copy link

This is implicated in the ChipIgnite CLI tool. Marwan/Anton/DL to meet offline to determine path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants