-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add version check to precheck #230
Comments
Perhaps this should be a hard failure. |
@jeffdi I think this check might be better to be implemented in the user project's makefile, as the makefile is responsible for the user's environment, and is aware of which tag the user is currently using. We could print a warning that the precheck version is incorrect and exit, and provide the user with the target they can run to update precheck (which is |
@marwaneltoukhy i think that misses the objective. we want precheck to check its version against the current available. the point is not to lock in on a tag, but to enable us to roll out a new version and users will automatically be prompted to update the next time they run, regardless of the version of caravel_user_project they started their project with (which can be behind in many cases). |
there is never a case where a user should be using an old version of precheck. |
PR pending - still needs final review |
create new version of user flow with the proposed changes in the PR. |
This is implicated in the ChipIgnite CLI tool. Marwan/Anton/DL to meet offline to determine path. |
Add check to precheck that would compare its version to a version tag posted in a known file location on the precheck git repo.
If the current version is behind, post a warning (minimally) with instructions on how to update (e.g. make precheck).
The text was updated successfully, but these errors were encountered: