Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newrelic from edx-platform dependencies #829

Closed
2 tasks done
timmc-edx opened this issue Oct 15, 2024 · 3 comments
Closed
2 tasks done

Remove newrelic from edx-platform dependencies #829

timmc-edx opened this issue Oct 15, 2024 · 3 comments

Comments

@timmc-edx
Copy link
Member

timmc-edx commented Oct 15, 2024

newrelic should not be listed as a dependency of edx-platform -- we rely on the abstraction layer in edx-django-utils (and that library also declares a dependency on it).

A/C:

(Later we can look into DEPRing the newrelic dependency in edx-django-utils as well -- we should probably have extra-deps of edx-django-utils that pull in Datadog, New Relic, or OTel as needed, and which deployers can add to their additional package list.)

@timmc-edx timmc-edx converted this from a draft issue Oct 15, 2024
@timmc-edx timmc-edx mentioned this issue Oct 15, 2024
12 tasks
@robrap
Copy link
Contributor

robrap commented Oct 17, 2024

Maybe this whole ticket should just be replaced by a DEPR ticket?

@jristau1984 jristau1984 changed the title Remove newrelic from edx-platform dependencies Propose DEPR to remove newrelic from edx-platform dependencies Oct 21, 2024
@jristau1984
Copy link

Tim confirmed there are several other repos with this reference in python code, but edx-platform is not in that list. Remove NR from the edx-platform requirements list.

DEPR from django-utils can be done at a future time.

@jristau1984 jristau1984 moved this to Ready For Development in Arch-BOM Oct 21, 2024
@jristau1984 jristau1984 changed the title Propose DEPR to remove newrelic from edx-platform dependencies Remove newrelic from edx-platform dependencies Oct 21, 2024
@timmc-edx
Copy link
Member Author

Completed, and ticket updated to scope the work down.

@github-project-automation github-project-automation bot moved this from Ready For Development to Done in Arch-BOM Oct 21, 2024
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arch-BOM Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - Long Term Storage
Development

No branches or pull requests

3 participants