Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Message: clarify if the provider certificate has expired. #2748

Open
llemeurfr opened this issue Jan 10, 2025 · 3 comments
Open

User Message: clarify if the provider certificate has expired. #2748

llemeurfr opened this issue Jan 10, 2025 · 3 comments
Assignees

Comments

@llemeurfr
Copy link
Contributor

If a user imports an LCP license which is invalid because the X509 provider certificate has expired, two user messages currently appear:

Invalid license signature date
Importing [C:\Users\xxxx\Downloads\550019e0-85b8-416f-8529-37b1ca73ef27.lcpl] failed: [Error: [Invalid LCP license signature date.] (C:\Users\xxxx\Downloads\550019e0-85b8-416f-8529-37b1ca73ef27.lcpl)]

Which is cryptic. Neither the user nor the provider can make anything useful with such a message.

Please replace it with the following unique message:

Incorrect license issue date 09 Jan 25 18:49 UTC, the provider certificate has expired on 04 Jan 25 23:59 UTC

or if the certificate expiry date is not easily available
Incorrect license issue date 09 Jan 25 18:49 UTC, the provider certificate has expired before this date

Ps: at least the provider can react to this new message.

@danielweck
Copy link
Member

danielweck commented Jan 10, 2025

"licenseSignatureDateInvalid": "Invalid LCP license signature date.",

// // License has been issued by an expired certificate
// LICENSE_SIGNATURE_DATE_INVALID = 111,

case 111: {
// message = "LICENSE_SIGNATURE_DATE_INVALID: " + val;
message = this.translator.translate("publication.licenseSignatureDateInvalid");
break;
}

@danielweck
Copy link
Member

Note that in the backend / low-level LCP lib, the symbolic enum name LICENSE_SIGNATURE_DATE_INVALID was renamed tro LICENSE_CERTIFICATE_DATE_INVALID but the error code remains 111 for backwards compatibility.

@danielweck
Copy link
Member

I am re-opening this issue as the fix in the develop branch is incomplete, we can probably improve the error message by adding date(s), and we will need to fix all translations other than EN and FR 42d136a

@danielweck danielweck reopened this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants