Passing tests

edmondop · Jul 24, 2024 · 0e1d2c4 · 0e1d2c4
1 parent 1667047
commit 0e1d2c4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/datafusion/physical-expr/src/aggregate/groups_accumulator/mod.rs b/datafusion/physical-expr/src/aggregate/groups_accumulator/mod.rs
@@ -25,5 +25,3 @@ pub(crate) mod accumulate {
 }
 
 pub use datafusion_physical_expr_common::aggregate::groups_accumulator::accumulate::NullState;
-
-pub(crate) mod prim_op {}
diff --git a/datafusion/proto/tests/cases/roundtrip_physical_plan.rs b/datafusion/proto/tests/cases/roundtrip_physical_plan.rs
@@ -24,6 +24,7 @@ use std::vec;
 
 use arrow::array::RecordBatch;
 use arrow::csv::WriterBuilder;
+use datafusion_functions_aggregate::min_max::max_udaf;
 use prost::Message;
 
 use crate::cases::{MyAggregateUDF, MyAggregateUdfNode, MyRegexUdf, MyRegexUdfNode};
@@ -81,7 +82,6 @@ use datafusion_common::file_options::json_writer::JsonWriterOptions;
 use datafusion_common::parsers::CompressionTypeVariant;
 use datafusion_common::stats::Precision;
 use datafusion_common::{internal_err, not_impl_err, DataFusionError, Result};
-use datafusion_expr::test::function_stub::Max;
 use datafusion_expr::{
     Accumulator, AccumulatorFactoryFunction, AggregateUDF, ColumnarValue, ScalarUDF,
     Signature, SimpleAggregateUDF, WindowFrame, WindowFrameBound,
@@ -953,9 +953,8 @@ fn roundtrip_scalar_udf_extension_codec() -> Result<()> {
         )),
         input,
     )?);
-    let udaf = AggregateUDF::from(Max::new());
     let aggr_expr = create_aggregate_expr(
-        &udaf,
+        &max_udaf(),
         &[udf_expr.clone()],
         &[],
         &[],
Original file line number	Diff line number	Diff line change
Expand Up		@@ -25,5 +25,3 @@ pub(crate) mod accumulate {
		}

		pub use datafusion_physical_expr_common::aggregate::groups_accumulator::accumulate::NullState;

		pub(crate) mod prim_op {}