From c1c7d1c37ed0b0ddd95384963c6ce245d16afb0d Mon Sep 17 00:00:00 2001 From: Theo Butler Date: Wed, 4 Dec 2024 10:08:09 -0500 Subject: [PATCH] fix: client_request span triggers --- src/middleware/request_tracing.rs | 11 +++-------- src/network/errors.rs | 2 -- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/middleware/request_tracing.rs b/src/middleware/request_tracing.rs index ad4fb6688..35c6c3d79 100644 --- a/src/middleware/request_tracing.rs +++ b/src/middleware/request_tracing.rs @@ -35,16 +35,11 @@ where } fn call(&mut self, req: Request) -> Self::Future { - // Create a tracing span for the client request and enter it. This way events created by the different layers - // in the middleware stack are associated with it. - let client_request_span = tracing::info_span!( - "client_request", // name + self.inner.call(req).instrument(tracing::info_span!( + "client_request", request_id = field::Empty, selector = field::Empty, - ) - .entered(); - - self.inner.call(req).instrument(client_request_span.clone()) + )) } } diff --git a/src/network/errors.rs b/src/network/errors.rs index 6519fc57c..8057c9435 100644 --- a/src/network/errors.rs +++ b/src/network/errors.rs @@ -71,8 +71,6 @@ impl From for ResolutionError { UnavailableReason::IndexerResolutionError(reason) } IndexerInfoResolutionError::IndexerServiceVersionResolutionFailed(err) => { - tracing::debug!(error=?err, "indexer service version resolution failed"); - let reason = match err { VersionResolutionError::FetchError(_) => { "indexer service version resolution failed"