Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT test for Issue 4653 #4688

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

zladdi
Copy link
Contributor

@zladdi zladdi commented Feb 4, 2025

  • External dependency org.apache.commons:commons-lang3-${commons-lang3.version}.jar is downloaded and placed into target.eagerResolver/dependee/lib at build time using maven-dependency-plugin.
  • Please also review the naming of the project, naming and placement of the test class, and naming and placement of the other files and let me know if adjustments are requested.

@laeubi
Copy link
Member

laeubi commented Feb 5, 2025

@zladdi you need to sing the ECA see https://api.eclipse.org/git/eca/status/gh/eclipse-tycho/tycho/4688 just create an eclipse account with your email address you use for github and put your github user id into the account details.

@laeubi
Copy link
Member

laeubi commented Feb 6, 2025

@zladdi it looks all good now, can you squash all your commits into one and probably rebase on current main branch?

Add license header

Add license header

Add license header
@zladdi zladdi force-pushed the issue_4653_reproducer branch from e67fbef to 5b096c1 Compare February 6, 2025 20:12
@zladdi
Copy link
Contributor Author

zladdi commented Feb 6, 2025

@zladdi it looks all good now, can you squash all your commits into one and probably rebase on current main branch?

Done

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Test Results

  609 files  +3    609 suites  +3   4h 3m 1s ⏱️ - 20m 34s
  435 tests +1    427 ✅ +1   7 💤 ±0  1 ❌ ±0 
1 305 runs  +3  1 282 ✅ +3  22 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 5b096c1. ± Comparison against base commit 481f161.

@laeubi laeubi merged commit 69f9754 into eclipse-tycho:main Feb 8, 2025
14 of 16 checks passed
@laeubi
Copy link
Member

laeubi commented Feb 8, 2025

Thanks for the testcase @zladdi

@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants