Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display.withCrLf() is producing wrong line breaks on Windows #1557

Closed
Christopher-Hermann opened this issue Oct 25, 2024 · 3 comments · Fixed by #1708 · May be fixed by #1562
Closed

Display.withCrLf() is producing wrong line breaks on Windows #1557

Christopher-Hermann opened this issue Oct 25, 2024 · 3 comments · Fixed by #1708 · May be fixed by #1562
Assignees
@Evgeni-Kramerov
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Christopher-Hermann
Copy link
Contributor

Christopher-Hermann commented Oct 25, 2024 •
edited
Loading

Describe the bug
Display.withCrLf() is producing wrong line breaks based on the heuristics in the Windows implementation. This happens only for Strings that contains broken formatting itself. But nevertheless, I think we can fix this issue by improving the method implementation.

To Reproduce
See Test case

	@Test
	public void testMixedLfAndCrflOnWindows() {
		if (!SWT.getPlatform().equals("win32")) {
			return;
		}

		String act = Display.withCrLf("First Line \n second line \r\n third line");

		assertEquals("First Line \r\n second line \r\n third line", act);
	}

Expected behavior
Expectation is that the method replaces all standalone \n with \r\n.
With the given example, \r\n results in \r\r\n

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

  1. Select the platform(s) on which the behavior is seen:
    • All OS
    • Windows
    • Linux
    • macOS
@Christopher-Hermann Christopher-Hermann added the good first issue Good for newcomers label Oct 25, 2024
@Evgeni-Kramerov
Copy link

@Christopher-Hermann
Hi,
Could you please assign this issue to me, I would love to fix it.
Thanks!

@HannesWell
Copy link
Member

Could you please assign this issue to me, I would love to fix it.

Just assigned it to you, but you can of course also work on an issue even if it hasn't been assigned to you :)
Just leave a note that you are working on it to avoid concurrent work.

Btw. if you are looking for a guide to help you through your contribution please try out https://github.com/eclipse-ide, which we are currently building for exactly that situation.

@jukzi jukzi added the bug Something isn't working label Oct 28, 2024
Evgeni-Kramerov added a commit to Evgeni-Kramerov/eclipse.platform.swt that referenced this issue Oct 28, 2024
@Evgeni-Kramerov
Display.withCrLf() is producing wrong line breaks on Windows eclipse-…
a2045d4 
…platform#1557

Changes functions so line breaks display correctly in Windows.

Fixes eclipse-platform#1557
@Evgeni-Kramerov Evgeni-Kramerov mentioned this issue Oct 28, 2024
Open
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.swt that referenced this issue Jan 7, 2025
@Christopher-Hermann
Display.withCrLf() is producing wrong line breaks on Windows
7d04b13 
Replacing all line breaks on windows with CrLf using regex, which is much safer.

Fixes eclipse-platform#1557
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.swt that referenced this issue Jan 7, 2025
@Christopher-Hermann
Display.withCrLf() is producing wrong line breaks on Windows
e4017cd 
Replacing all line breaks on windows with CrLf using regex, which is much safer.

Fixes eclipse-platform#1557
@Christopher-Hermann Christopher-Hermann mentioned this issue Jan 7, 2025
Merged
@Christopher-Hermann
Copy link
Contributor Author

Uploaded a PR since we need this fix in our product and there was no action for some time

Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.swt that referenced this issue Jan 7, 2025
@Christopher-Hermann
Display.withCrLf() is producing wrong line breaks on Windows
7552d5b 
Replacing all line breaks on windows with CrLf using regex, which is much safer.

Fixes eclipse-platform#1557
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.swt that referenced this issue Jan 7, 2025
@Christopher-Hermann
Display.withCrLf() is producing wrong line breaks on Windows
8b6003b 
Replacing all line breaks on windows with CrLf using regex, which is much safer.

Fixes eclipse-platform#1557
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.swt that referenced this issue Jan 8, 2025
@Christopher-Hermann
Display.withCrLf() is producing wrong line breaks on Windows
acfa734 
Replacing all line breaks on windows with CrLf using regex, which is much safer.

Fixes eclipse-platform#1557
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.swt that referenced this issue Jan 8, 2025
@Christopher-Hermann
Display.withCrLf() is producing wrong line breaks on Windows
889de2c 
Replacing all line breaks on windows with CrLf using regex, which is much safer.

Fixes eclipse-platform#1557
Christopher-Hermann added a commit to Christopher-Hermann/eclipse.platform.swt that referenced this issue Jan 8, 2025
@Christopher-Hermann
Display.withCrLf() is producing wrong line breaks on Windows
fcaa4c2 
Replacing all line breaks on windows with CrLf using regex, which is much safer.

Fixes eclipse-platform#1557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evgeni-Kramerov Evgeni-Kramerov

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@HannesWell @jukzi @Christopher-Hermann @Evgeni-Kramerov