JDK24 remove System.getSecurityManager part 3 #21039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Jan 29, 2025
...rc/java.management/share/classes/com/ibm/java/lang/management/internal/MemoryMXBeanImpl.java
Show resolved
Hide resolved
jcl/src/openj9.sharedclasses/share/classes/com/ibm/oti/shared/SharedAbstractHelper.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
securitymanager_3
branch
2 times, most recently
from
3129c8b to
7704946
Compare
keithc-ca
requested changes
Jan 30, 2025
jcl/src/openj9.sharedclasses/share/classes/com/ibm/oti/shared/SharedAbstractHelper.java
Outdated
Show resolved
Hide resolved
jcl/src/openj9.sharedclasses/share/classes/com/ibm/oti/shared/SharedClassHelperFactoryImpl.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
securitymanager_3
branch
3 times, most recently
from
23df3d3 to
8501b70
Compare
JasonFengJ9
reviewed
Jan 30, 2025
jcl/src/openj9.sharedclasses/share/classes/com/ibm/oti/shared/SharedClassUtilities.java
Show resolved
Hide resolved
| @@ -223,8 +223,11 @@ public Integer run() { | |||
| * @param filter the filter to use when finding and storing classes | |||
| */ | |||
| @Override | |||
| /*[IF JAVA_SPEC_VERSION < 24]*/ | |||
There was a problem hiding this comment.
import java.security.AccessController;
import java.security.PrivilegedAction;
L30-31 can be removed for JDK24+.
There was a problem hiding this comment.
The AccessController.doPrivileged use in this file is still there. I will remove this in a seperate pull request.
Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
securitymanager_3
branch
from
8501b70 to
f5a3419
Compare
|
Jenkins test sanity plinux jdk21,jdk24 |
keithc-ca
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanity.functional: https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/26075/
extended.functional: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/47119/
Related: #20563