Prevent redundant call transformation #20951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsankianifar
force-pushed
the
PreventRedundantGetComponentTypeCallTransformation
branch
from
eb013df to
26276d4
Compare
|
I tested manually. Works as expected. currently running some JDK8, 11, and 21 builds. |
hzongaro
approved these changes
Jan 16, 2025
|
Jenkins test sanity.functional,sanity.openjdk xlinux,alinux jdk8,jdk17,jdk21 |
|
Sorry I missed this, but once testing has completed, may I ask you to update the commit comment so that each line is no more than 72 characters long, as described in the Commit Guidelines? |
|
@ehsankianifar, it looks CI testing ran successfully. May I ask you to update the commit comment? |
Redundant getComponentType() transformation was observed in value-propagation optimization. Adding condition to perform this transformation only in last time through run. Signed-off-by: Ehsan Kiani Far <[email protected]>
|
All the checks passed. I Amend the commit to fix Description length. |
ehsankianifar
force-pushed
the
PreventRedundantGetComponentTypeCallTransformation
branch
from
26276d4 to
c5e34bb
Compare
hzongaro
approved these changes
Jan 17, 2025
|
This is a very safe change, and testing was completely successful. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redundant getComponentType() transformation was observed in value propagation optimization. Adding condition to perform this transformation only in last time through run.
@hzongaro