Adding in jfr thread statistics event. #20948
Conversation
adpopescu
force-pushed
the
jfr-threadstats
branch
from
3852b3a to
e051f74
Compare
|
@tajila Please review. |
Which issues did you see? |
|
For me, the event never actually appeared properly in JMC and it kept throwing an error. I'm assuming it's because the buffer that the data was being put in, was not the correct size and therefore some sections were overwritten or omitted. Regardless the buffer that's being used with calculateRequiredBufferSize() in JFRChunkWriter.hpp is still currently being used so I can't remove the indexes yet? I had forgotten to put the size of the thread park events into the buffer calculation. After this change it seems to appear correctly now. |
|
Oh I see. |
|
Can you put the threadpark changes in a separate PR. We need to get those in ASAP for the next release. The threadstats changes are not as urgent. |
|
Ah yes I see that now... Ok I will change that back and put them in another PR. |
Signed-off-by: Adrian Popescu <[email protected]>
adpopescu
changed the title
adpopescu
force-pushed
the
jfr-threadstats
branch
from
e051f74 to
e434c1d
Compare
|
Removed the thread park fixes. Might have to rebase this PR once those are in. |
Adding in the thread stats event. I noticed some issues with the thread park as well due to the removal of the index and count variables so I added those back in.