Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK next removes ASM from java.base #20938

Open
JasonFengJ9 opened this issue Jan 15, 2025 · 4 comments
Open

JDK next removes ASM from java.base #20938

JasonFengJ9 opened this issue Jan 15, 2025 · 4 comments
Assignees
@keithc-ca
Labels
comp:vm jdk-head
Milestone
Java 25

Comments

@JasonFengJ9
Copy link
Member

Failure link

From https://openj9-jenkins.osuosl.org/job/Build_JDKnext_aarch64_linux_OpenJDK/713/consoleFull

Optional info

Failure output (captured from console output)

00:53:41  /home/jenkins/workspace/Build_JDKnext_aarch64_linux_OpenJDK/build/linux-aarch64-server-release/support/gensrc/java.base/module-info.java:234: error: package is empty or does not exist: jdk.internal.org.objectweb.asm
00:53:41      exports jdk.internal.org.objectweb.asm to
00:53:41                                        ^

OpenJDK update
@JasonFengJ9 JasonFengJ9 added this to the Java 25 milestone Jan 15, 2025
@pshipton
Copy link
Member

@keithc-ca fyi, this is going to affect creation of DDR.

@pshipton
Copy link
Member

The failure is due to

    exports jdk.internal.org.objectweb.asm to
        openj9.dtfj,
        openj9.dtfjview;

@pshipton
Copy link
Member

@tajila fyi

@keithc-ca keithc-ca self-assigned this Jan 15, 2025
pshipton added a commit to pshipton/openj9-openjdk-jdk that referenced this issue Jan 21, 2025
@pshipton
Temporarily restore ASM until DDR is fixed to use classfile API
ce7d84c 
Restore jdk.internal.org.objectweb in java.base, but don't revert
OpenJDK test changes.

Related to
ibmruntimes@a778fb5131

Issue eclipse-openj9/openj9#20938

Signed-off-by: Peter Shipton <[email protected]>
@pshipton pshipton mentioned this issue Jan 21, 2025
Merged
@pshipton
Copy link
Member

Temporarily restore ASM in ibmruntimes/openj9-openjdk-jdk#919
It will need to be removed again once Keith updates DDR to use the ClassFile API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithc-ca keithc-ca

Labels
comp:vm jdk-head
Projects
None yet
Milestone
Java 25
Development

No branches or pull requests
3 participants
@keithc-ca @JasonFengJ9 @pshipton