You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
extended.openjdk PR build still shows the errors #16074 due to the test framework taking the default JDK19 extension repo instead of this PR.
Launched an internal grinder w/ this change and the three tests in question are skipped or passed.
So the ask is that any PR build that changes code in extensions, should pass JDK_REPO & JDK_BRANCH to the test jobs. Correct? I'm not sure I was thinking of the same known issue originally.
Does the test code have ability at the moment to fetch PR refs and checkout a merge ref of extensions repos @llxia?
So the ask is that any PR build that changes code in extensions, should pass JDK_REPO & JDK_BRANCH to the test jobs. Correct?
Yes, we need set JDK_REPO and JDK_BRANCH for the extensions repos in the test job.
Not sure what was the reason for setting the names differently in the job parameters.
Does the test code have ability at the moment to fetch PR refs and checkout a merge ref of extensions repos
The test job takes JDK_REPO, JDK_BRANCH and OPENJDK_SHA. If the correct ref is passed in, the test job is able to get the extension repo materials.
Copied from
extended.openjdk
PR build still shows the errors #16074 due to the test framework taking the default JDK19 extension repo instead of this PR.Launched an internal grinder w/ this change and the three tests in question are skipped or passed.
Originally posted by @JasonFengJ9 in ibmruntimes/openj9-openjdk-jdk19#34 (comment)
Related issues
Internal issue - OpenJ9 pipelines should pass openjdk repo/branch to test jobs
The text was updated successfully, but these errors were encountered: