-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The generate-vscode-jars
profile should not include lemminx jar and its dependencies
#529
Comments
@fbricon then how are we going run lemminx-maven in vscode-xml? |
Vscode-xml already provides lemminx and its dependencies. We only need lemminix-maven and its own specific dependencies |
@fbricon I think this is still a question in case of vscode-xml is set to use a lemminx binary |
no, the lemminx uber jar is always shipped in vcode-xml, whether you use the binary or not. |
vscode-uber-jars also contains some extra dependencies such as junit, which is only a test scope dependency..? But yeah the specific artifacts to be included needs to be cleaned out more thoroughly. |
When running
mvn clean verify -DskipTests -Dinvoker.skip=true -Pgenerate-vscode-jars
, the lemminx jar and its dependencies (including tests), should be excluded.The text was updated successfully, but these errors were encountered: