Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol connection events #565

Closed
ctron opened this issue Apr 10, 2018 · 6 comments
Closed

Protocol connection events #565

ctron opened this issue Apr 10, 2018 · 6 comments
Assignees
@ctron
Labels
EclipseInt Tasks related to integration of existing components within Eclipse IoT WG enhancement MQTT Adapter
Milestone
0.6

Comments

@ctron
Copy link
Contributor

ctron commented Apr 10, 2018

In addition to the device notification functionality, we discussed in Berlin that we do need some kind event which notifies of the fact that "someone" (not necessarily a device) connected.

This would be a more "debug" like event and might not make sense for all protocol adapters. It may however make sense for MQTT, where a connection can be successfully established and be kept open for a longer period of time. This might be useful when the device/gateway connections successfully, but doesn't transmit any data over the MQTT link.

The same might be useful for the (hopefully) upcoming AMQP protocol adapter.

This functionality should not be seen as a replacement for the "device notification" feature currently being discussed in #562, #535 and #537.

My proposal would be to start with an interface which being called to handle those events. Providing a "logging only" implementation.

I tried to re-cap in this issue the discussion we had in the last Hono call, splitting off the "device notification" we need for command & control, vs the MQTT connection notification event we need for better debugging.
@ctron ctron added this to the 0.6 milestone Apr 10, 2018
@ctron ctron added enhancement MQTT Adapter EclipseInt Tasks related to integration of existing components within Eclipse IoT WG labels Apr 10, 2018
@sophokles73
Copy link
Contributor

@ctron can we remove the term alerting from this issue? It seems to interfere with #502 which is about something different but might be mistaken for this one here.

@ctron
Copy link
Contributor Author

ctron commented Apr 10, 2018

can we remove the term alerting from this issue? It seems to interfere with #502 which is about something different but might be mistaken for this one here.

We could also send the notifications over this new "alerting" functionality. But we could change the naming of this functionality to not imply the alerting functionality has to be used.

@ctron ctron changed the title Device connection alerting Protocol connection events Apr 10, 2018
@ctron
Copy link
Contributor Author

ctron commented Apr 10, 2018

Maybe "protocol connection events" work better:

  • Actually we are not talking about devices/gateways here, but about connections on the side of the protocol adapter.
  • It is all about the technical connection which got opened with the protocol adapter

@sophokles73
Copy link
Contributor

But we could change the naming of this functionality to not imply the alerting functionality has to be used.

That was my concern.

@ctron
Copy link
Contributor Author

ctron commented Apr 10, 2018

Is the changed title an improvement?

ctron added a commit to ctron/hono that referenced this issue Apr 11, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
92cbe35
ctron added a commit to ctron/hono that referenced this issue Apr 11, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
bcf2619
@ctron ctron mentioned this issue Apr 11, 2018
Merged
ctron added a commit to ctron/hono that referenced this issue Apr 11, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
e44ebcd
ctron added a commit to ctron/hono that referenced this issue Apr 11, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
a43e5a1
ctron added a commit to ctron/hono that referenced this issue Apr 11, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
03c8982
ctron added a commit to ctron/hono that referenced this issue Apr 13, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
833ceb9
ctron added a commit to ctron/hono that referenced this issue Apr 16, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
48ccf2e
ctron added a commit to ctron/hono that referenced this issue Apr 16, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
47d59d0
ctron added a commit to ctron/hono that referenced this issue Apr 16, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
43654ff
ctron added a commit to ctron/hono that referenced this issue Apr 16, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
6b6c644
ctron added a commit to ctron/hono that referenced this issue Apr 16, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
bbbdb15
ctron added a commit to ctron/hono that referenced this issue Apr 18, 2018
@ctron
[eclipse-hono#565] Drop abitlity to specify logger levels
bc5710f
ctron added a commit to ctron/hono that referenced this issue Apr 18, 2018
@ctron
[eclipse-hono#565] Drop ability to specify logger levels
1da309b
ctron added a commit to ctron/hono that referenced this issue Apr 18, 2018
@ctron
[eclipse-hono#565] Drop ability to specify logger levels
371d0be
ctron added a commit to ctron/hono that referenced this issue May 4, 2018
@ctron
[eclipse-hono#565] Implement protocol connection events
d3a2a5a 
This change adds connection events which protocol adapters may send out
in order to notify listeners that a device has connected/disconnected.

Those events are "best effort", but there are no guarantees about them.
Hono supports different ways of handling those events and comes with two
default implementations. One "logging" implementation which simply logs
to the logging system. And one event base implementation, which sends
out events using the *Hono Event API*. The implementations may be wired
up using the Spring Boot configuration.
ctron added a commit that referenced this issue May 4, 2018
@ctron
[#565] Implement protocol connection events
f0205f9 
This change adds connection events which protocol adapters may send out
in order to notify listeners that a device has connected/disconnected.

Those events are "best effort", but there are no guarantees about them.
Hono supports different ways of handling those events and comes with two
default implementations. One "logging" implementation which simply logs
to the logging system. And one event base implementation, which sends
out events using the *Hono Event API*. The implementations may be wired
up using the Spring Boot configuration.
@ctron
Copy link
Contributor Author

ctron commented May 4, 2018

Closed by PR #569

@ctron ctron closed this as completed May 4, 2018
@sysexcontrol sysexcontrol mentioned this issue May 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctron ctron

Labels
EclipseInt Tasks related to integration of existing components within Eclipse IoT WG enhancement MQTT Adapter
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@ctron @sophokles73