Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus based resource limit check is hardcoded to use port 9090 only #3647

Closed
harism opened this issue Jun 19, 2024 · 2 comments
Closed

Prometheus based resource limit check is hardcoded to use port 9090 only #3647

harism opened this issue Jun 19, 2024 · 2 comments
Labels
bug

Comments

@harism
Copy link
Contributor

harism commented Jun 19, 2024 •
edited
Loading

Unless I'm mistaken this single line;

hono/adapter-base/src/main/java/org/eclipse/hono/adapter/resourcelimits/PrometheusBasedResourceLimitChecksConfig.java

Line 71 in 6a05ee3

setPort(9090);

Causes it that the documented configurable Prometheus port variable is always overrode with this 9090 value, and the configuration variable hono.resourceLimits.prometheusBased.port coming in the PrometheusBasedResourceLimitCheckOptions constructor parameter has no effect.
harism added a commit to harism/hono that referenced this issue Jun 19, 2024
@harism
[eclipse-hono#3647] Prometheus based limits check uses always port 9090
699035e
harism added a commit to harism/hono that referenced this issue Jun 19, 2024
@harism
[eclipse-hono#3647] Prometheus based limits check uses always port 9090
630121c
@sophokles73
Copy link
Contributor

I guess you are right.

harism added a commit to harism/hono that referenced this issue Jun 20, 2024
@harism
[eclipse-hono#3647] Prometheus based limits check uses always port 9090
0284ffe
sophokles73 pushed a commit that referenced this issue Jun 21, 2024
@harism @sophokles73
[#3647] Prometheus based limits check uses always port 9090
a4f0e2f
@sophokles73
Copy link
Contributor

Fixed via #3648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harism @sophokles73