From 351ef4483e0f107632a2d73abb9f904c11ad3acc Mon Sep 17 00:00:00 2001 From: Eclipse Equinox Bot Date: Wed, 29 Jan 2025 03:25:35 +0000 Subject: [PATCH] Perform clean code of bundles/org.eclipse.equinox.p2.updatesite --- .../internal/p2/updatesite/RemoteUpdateSiteAction.java | 2 +- .../equinox/internal/p2/updatesite/UpdateSite.java | 10 +++++----- .../artifact/UpdateSiteArtifactRepository.java | 4 ++-- .../metadata/UpdateSiteMetadataRepository.java | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/RemoteUpdateSiteAction.java b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/RemoteUpdateSiteAction.java index 53fb8b936..65309e4ec 100644 --- a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/RemoteUpdateSiteAction.java +++ b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/RemoteUpdateSiteAction.java @@ -27,7 +27,7 @@ * IUs generated for the bundles are "partial" as the bundles themselves are not downloaded. */ public class RemoteUpdateSiteAction implements IPublisherAction { - private UpdateSite updateSite; + private final UpdateSite updateSite; private final String categoryQualifier; /** diff --git a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/UpdateSite.java b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/UpdateSite.java index 90b1e7995..d36746df7 100644 --- a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/UpdateSite.java +++ b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/UpdateSite.java @@ -45,10 +45,10 @@ public class UpdateSite { private static final int RETRY_COUNT = 2; private static final String DOT_XML = ".xml"; //$NON-NLS-1$ private static final String SITE = "site"; //$NON-NLS-1$ - private String checksum; - private URI location; - private URI rootLocation; - private SiteModel site; + private final String checksum; + private final URI location; + private final URI rootLocation; + private final SiteModel site; /* * Some variables for caching. @@ -61,7 +61,7 @@ public class UpdateSite { private Map featureCache = new HashMap<>(); // map of String (bundleID_featureVersion) to BundleDescriptr private Map bundleCache = new HashMap<>(); - private Transport transport; + private final Transport transport; /* * Return a URI based on the given URI, which points to a site.xml file. diff --git a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/artifact/UpdateSiteArtifactRepository.java b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/artifact/UpdateSiteArtifactRepository.java index 623729545..629962108 100644 --- a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/artifact/UpdateSiteArtifactRepository.java +++ b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/artifact/UpdateSiteArtifactRepository.java @@ -32,8 +32,8 @@ public class UpdateSiteArtifactRepository implements IArtifactRepository { public static final String TYPE = "org.eclipse.equinox.p2.updatesite.artifactRepository"; //$NON-NLS-1$ public static final String VERSION = Integer.toString(1); - private URI location; - private IArtifactRepository delegate; + private final URI location; + private final IArtifactRepository delegate; public UpdateSiteArtifactRepository(URI location, IArtifactRepository repository) { this.location = location; diff --git a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/metadata/UpdateSiteMetadataRepository.java b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/metadata/UpdateSiteMetadataRepository.java index c4e9abcda..2723bebbe 100644 --- a/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/metadata/UpdateSiteMetadataRepository.java +++ b/bundles/org.eclipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/metadata/UpdateSiteMetadataRepository.java @@ -33,8 +33,8 @@ public class UpdateSiteMetadataRepository implements IMetadataRepository { public static final String TYPE = "org.eclipse.equinox.p2.updatesite.metadataRepository"; //$NON-NLS-1$ public static final String VERSION = Integer.toString(1); - private URI location; - private IMetadataRepository delegate; + private final URI location; + private final IMetadataRepository delegate; public UpdateSiteMetadataRepository(URI location, IMetadataRepository repository) { this.location = location;