Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential problem with multiple org.osgi.service.component.annotations packages #157

Closed
merks opened this issue Nov 12, 2022 · 5 comments
Closed
Labels

Comments

@merks
Copy link
Contributor

merks commented Nov 12, 2022

Testing the platform's 4.26 I-Build for split-package signature problems, this one crops up:

  1. org.osgi.service.component.annotations
    • [org.eclipse.osgi.services 3.11.100.v20221006-1531, org.osgi.service.component.annotations 1.5.0.202109301733]
    • {CN=Eclipse.org Foundation, Inc., OU=IT, O=Eclipse.org Foundation, Inc., L=Ottawa, ST=Ontario, from=2022-05-02, to=2024-05-22}
    • unsigned

The first one is this and is jar signed:

https://download.eclipse.org/oomph/archive/reports-extra/4.26-I-builds/download.eclipse.org/eclipse/updates/4.26-I-builds/I20221111-1800/index/org.eclipse.osgi.services_3.11.100.v20221006-1531.html

The second one is this and is PGP signed:

https://download.eclipse.org/oomph/archive/reports-extra/4.26-I-builds/download.eclipse.org/eclipse/updates/4.26-I-builds/I20221111-1800/index/org.osgi.service.component.annotations_1.5.0.202109301733.html

Should this one

image

really have a copy of the content from this one

image

I suppose running system will just pick one of two packages and not actually encounter a problem with loading a class form one package and then a different class from the other package, but it still seems odd to duplicate the content. Though I guess it's not actually a duplicate because one is version 1.3 and the other version 1.5.

Is this state actually the desired correct one?

@laeubi
Copy link
Member

laeubi commented Nov 12, 2022

Today I think the most suitable solution would be to not publish org.eclipse.osgi.services at all (we can always use the official artifact from the osgi alliance instead). Beside that. all these annotations are actually class retention annotations, so should never be loaded at runtime at all.

@HannesWell
Copy link
Member

This situation is expected (but not desired) since the transition to OSGi-bundles from Maven-Central has started in #18 but is not yet completed. It is currently blocked by eclipse-platform/eclipse.platform.releng.aggregator#239 not being available, which was blocked by eclipse-equinox/p2#64. But we resolved the latter we just have to wait until that is available in Tycho and then (hopefully) can proceed after the december SimRel.

Unfortunately the strategy to replace the previously embedded OSGi sources by bundles from Maven-Central and simply re-exporting them until o.e.osgi.services is eventually removed cannot be applied to the packages you mentioned because of #18 (comment).
However, after the december release we should eventually be able to start their fade-out.

@laeubi
Copy link
Member

laeubi commented Nov 12, 2022

This situation is expected (but not desired)

I think there is actually nothing special or something one must be concerned, this is not a split package and just a regular package in different versions.

@merks
Copy link
Contributor Author

merks commented Mar 1, 2023

I guess we don't need to worry about this problem...

@github-actions
Copy link

This issue has been inactive for 180 days and is therefore labeled as stale.
If this issue became irrelevant in the meantime please close it as completed. If it is still relevant and you think it should be fixed some possibilities are listed below.
Please read https://github.com/eclipse-equinox/.github/blob/main/CONTRIBUTING.md#contributing-to-eclipse-equinox for ways to influence development.

@github-actions github-actions bot added the stale label Aug 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants