Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling/disabling commit Signed-off-by on a per-repository basis #55

Open
sebthom opened this issue Sep 6, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@sebthom
Copy link

sebthom commented Sep 6, 2024

Description

EGit provides a global setting to automatically include "Signed-off-by" messages in commits.

image

I propose adding an option to enable/disable this setting on a per-git-repository basis.

Motivation

In my workspace, I work on projects from various contexts (open-source, in-house, client projects, etc.), each with its own commit policies. Some projects require "Signed-off-by" messages, while for others, it’s unnecessary and just noise.

Currently, I have the global setting disabled and manually amend commits as needed. However, when switching between projects, I sometimes forget to adjust this, which leads to issues that I only notice after a failed PR or CI run. This can be time-consuming and frustrating.

Alternatives considered

No response

Additional context

No response

@sebthom sebthom added the enhancement New feature or request label Sep 6, 2024
@tomaswolf
Copy link
Contributor

Wouldn't it make more sense to have this as a per-repository setting?

@sebthom sebthom changed the title Allow enabling/disabling commit Signed-off-by on a per-project basis Allow enabling/disabling commit Signed-off-by on a per-repository basis Sep 9, 2024
@sebthom
Copy link
Author

sebthom commented Sep 9, 2024

@tomaswolf that's what I basically meant. :-) Thanks for your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants