Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringSettingsProperty Never Validates if regExp is "" #36

Closed
kerner1000 opened this issue Sep 28, 2019 · 4 comments
Closed

StringSettingsProperty Never Validates if regExp is "" #36

kerner1000 opened this issue Sep 28, 2019 · 4 comments
Assignees
@kerner1000
Milestone
0.8.x

Comments

@kerner1000
Copy link
Contributor

If the regex is empty, the property does not validate.
@kerner1000 kerner1000 self-assigned this Sep 28, 2019
kerner1000 added a commit that referenced this issue Sep 28, 2019
@kerner1000
Fix #36
ed58c5a
@laeubi
Copy link
Contributor

laeubi commented Sep 29, 2019

What should it validate? an empty regexp makes no sense at all?

@laeubi laeubi closed this as completed in f92601d Sep 29, 2019
@kerner1000
Copy link
Contributor Author

Why should an input String always be regex-validated? What if the expected input is a name or country? Do you have a regex for that?

@kerner1000 kerner1000 reopened this Sep 30, 2019
@kerner1000 kerner1000 mentioned this issue Sep 30, 2019
Merged
@laeubi
Copy link
Contributor

laeubi commented Sep 30, 2019

You simply don't need ANYthing for this, you must not annotate a String as "StringSettingsProperty!"

@laeubi laeubi closed this as completed Sep 30, 2019
@kerner1000
Copy link
Contributor Author

See #43.

kerner1000 added a commit that referenced this issue Sep 30, 2019
@kerner1000
Squashed commit of the following:
b9788db 
commit bfaf0d3
Author: Christoph Läubrich <[email protected]>
Date:   Mon Sep 30 10:19:05 2019 +0200

    Fix #42

commit a6a2a59
Author: Christoph Läubrich <[email protected]>
Date:   Sun Sep 29 19:19:43 2019 +0200

    #39 add option to use a preference page instead of a button

commit f92601d
Author: Christoph Läubrich <[email protected]>
Date:   Sun Sep 29 18:13:05 2019 +0200

    Fix #36

commit 97ac273
Author: Christoph Läubrich <[email protected]>
Date:   Sun Sep 29 14:49:03 2019 +0200

    Fix #39

commit 8f3aa74
Author: Christoph Läubrich <[email protected]>
Date:   Fri Sep 27 15:14:28 2019 +0200

    Fix #33

commit 5b0845d
Author: Christoph Läubrich <[email protected]>
Date:   Fri Sep 27 15:00:11 2019 +0200

    Fix #32

commit 7e18420
Author: Christoph Läubrich <[email protected]>
Date:   Fri Sep 27 08:31:32 2019 +0200

    Fix #31

commit 8a26934
Author: Christoph Läubrich <[email protected]>
Date:   Fri Sep 27 07:51:44 2019 +0200

    Refactoring to support #31

commit b8aad6a
Author: Christoph Läubrich <[email protected]>
Date:   Thu Sep 26 19:40:47 2019 +0200

    Refactoring to support #31
laeubi pushed a commit that referenced this issue Oct 4, 2019
@kerner1000
Fix #34, #36, #37 (#35)
a16b753 
Fix #34, #36, #37, #35
@laeubi laeubi added this to the 0.8.x milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerner1000 kerner1000

Labels
None yet
Projects
None yet
Milestone
0.8.x
Development

No branches or pull requests
2 participants
@laeubi @kerner1000