From 359be8837fea478f8fa87fc8d0bcf0c150fb1c61 Mon Sep 17 00:00:00 2001
From: Daniel <mail@danielluedecke.de>
Date: Tue, 5 Mar 2024 08:51:17 +0100
Subject: [PATCH] lintr

---
 tests/testthat/test-random_effects_ci.R | 36 +++++++++++++++++++------
 1 file changed, 28 insertions(+), 8 deletions(-)

diff --git a/tests/testthat/test-random_effects_ci.R b/tests/testthat/test-random_effects_ci.R
index a43955c12..13b01a30d 100644
--- a/tests/testthat/test-random_effects_ci.R
+++ b/tests/testthat/test-random_effects_ci.R
@@ -7,7 +7,7 @@ skip_on_cran()
 data(sleepstudy, package = "lme4")
 data(cake, package = "lme4")
 set.seed(123)
-sleepstudy$Months <- sample(1:4, nrow(sleepstudy), TRUE)
+sleepstudy$Months <- sample.int(4, nrow(sleepstudy), TRUE)
 
 m1 <- suppressMessages(lme4::lmer(
   angle ~ temperature + (temperature | recipe) + (temperature | replicate),
@@ -20,11 +20,31 @@ m5 <- suppressMessages(lme4::lmer(Reaction ~ Days + (Days + Months | Subject), d
 
 ## TODO also check messages for profiled CI
 
-expect_message(mp1 <- model_parameters(m1, ci_random = TRUE), "meaningful")
+expect_message(
+  {
+    mp1 <- model_parameters(m1, ci_random = TRUE)
+  },
+  regex = "meaningful"
+)
 mp2 <- model_parameters(m2, ci_random = TRUE)
-expect_message(mp3 <- model_parameters(m3, ci_random = TRUE), "meaningful")
-expect_message(mp4 <- model_parameters(m4, ci_random = TRUE), "meaningful")
-expect_message(mp5 <- model_parameters(m5, ci_random = TRUE), "meaningful")
+expect_message(
+  {
+    mp3 <- model_parameters(m3, ci_random = TRUE)
+  },
+  regex = "meaningful"
+)
+expect_message(
+  {
+    mp4 <- model_parameters(m4, ci_random = TRUE)
+  },
+  regex = "meaningful"
+)
+expect_message(
+  {
+    mp5 <- model_parameters(m5, ci_random = TRUE)
+  },
+  regex = "meaningful"
+)
 
 
 # model 1 ---------------------
@@ -239,7 +259,7 @@ test_that("random effects CIs, double slope", {
 test_that("random effects CIs, simple slope", {
   data(sleepstudy, package = "lme4")
   set.seed(123)
-  sleepstudy$Months <- sample(1:4, nrow(sleepstudy), TRUE)
+  sleepstudy$Months <- sample.int(4, nrow(sleepstudy), TRUE)
 
   m2 <- lme4::lmer(Reaction ~ Days + (0 + Days | Subject), data = sleepstudy)
   m5 <- lme4::lmer(Reaction ~ Days + (0 + Days + Months | Subject), data = sleepstudy)
@@ -280,9 +300,9 @@ test_that("random effects CIs, simple slope", {
 # poly random slope --------------------------
 test_that("random effects CIs, poly slope", {
   data(cake, package = "lme4")
-  suppressMessages(
+  suppressMessages({
     m <- lme4::lmer(angle ~ poly(temp, 2) + (poly(temp, 2) | replicate) + (1 | recipe), data = cake)
-  )
+  })
   mp <- model_parameters(m, ci_random = TRUE)
 
   expect_equal(