Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter-menu: Built-in search functionality #2331

Open
LuLaValva opened this issue Nov 22, 2024 · 2 comments
Open

filter-menu: Built-in search functionality #2331

LuLaValva opened this issue Nov 22, 2024 · 2 comments

Comments

@LuLaValva
Copy link
Member

Enhancement Request

  • Add optional automatic filtering of items in <ebay-filter-menu> via the search header

Description

  • For basic use cases, it may be useful for the filter menu to handle searching through items automatically

Note

I'm still not sure this is necessary, for the reasons outlined in #2330:

  • There are likely multiple types of custom filtering (i. e. case sensitive, beginning of term vs within term)
  • Simple cases that would likely be a good candidate for eBayUI to do the filtering should likely not even have a search filter to begin with
  • Network requests are impossible to handle in eBayUI

If this feature will never be used, it is unnecessary bloat for the component

Context

Screenshots

@agliga
Copy link
Contributor

agliga commented Jan 31, 2025

we should add this also to listbox-button

@agliga agliga added this to the 15.1.0 milestone Jan 31, 2025
@agliga agliga added the size: 2 label Jan 31, 2025
@agliga agliga self-assigned this Jan 31, 2025
@ianmcburnie
Copy link
Contributor

ianmcburnie commented Jan 31, 2025

Make sure not to implement this searchbox as role=combobox (i.e. it is not expected to access the items with ARROW keys while focus is on textbox). Keyboard user needs to explicitly tab from textbox to menu.

We'll update the MIND patterns with full guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants