Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebay-signal does not passthrough class #2121

Closed
mkchang opened this issue Mar 12, 2024 · 0 comments · Fixed by #2122
Closed

ebay-signal does not passthrough class #2121

mkchang opened this issue Mar 12, 2024 · 0 comments · Fixed by #2122
Assignees
@mkchang
Labels
component: signal

Comments

@mkchang
Copy link
Contributor

mkchang commented Mar 12, 2024

Bug Report

eBayUI Version: 13.2.0

Description

ebay-signal does not passthrough class attribute, e.g. when used like

<ebay-signal status=level class="ui-hotness-signal">

This seems to be a miss in #2039 as it is missing the class: inputClass added in other components.

Workaround

Screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkchang mkchang

Labels
component: signal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(signal): custom class passthrough mkchang/ebayui-core
2 participants
@mkchang @LuLaValva