Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tabs component #8

Open
RobjS opened this issue Jan 25, 2021 · 3 comments
Open

Add Tabs component #8

RobjS opened this issue Jan 25, 2021 · 3 comments

Comments

@RobjS
Copy link
Contributor

RobjS commented Jan 25, 2021

https://design-system.service.gov.uk/components/tabs/

@serena-piccioni
Copy link
Contributor

I'm not sure if it is a good idea to add this component, because, as explained into the documentation:

Do not use the tabs component if the total amount of content the tabs contain will make the page slow to load. For this reason, do not use the tabs component as a form of page navigation.

I think that any client would use it in this wrong way as a first choice.
Open to discussion of course :)

@RobjS
Copy link
Contributor Author

RobjS commented Jan 26, 2021

That's a good point. Hopefully the fact that the tabs can only be included in the main content will help to deter this (i.e. it can't be used to replace the main nav). But how about we include some kind of warning in the help text for the component?

@serena-piccioni
Copy link
Contributor

Good idea, and probably yes, the fact the it's in the main content should help deter users to abuse it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants