Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to dependency on elixir_auth_github to v1.5 and Update Phoenix to 1.6 #6

Closed
4 tasks done
nelsonic opened this issue Oct 5, 2021 · 1 comment
Closed
4 tasks done

Update to dependency on elixir_auth_github to v1.5 and Update Phoenix to 1.6 #6

nelsonic opened this issue Oct 5, 2021 · 1 comment
Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes

Comments

@nelsonic
Copy link
Member

nelsonic commented Oct 5, 2021 •
edited
Loading

With the release of elixir_auth_github at 1.5.0 and Phoenix 1.6 we need to update this demo to confirm everything still works as expected.

Todo

  • Update Elixir to 1.12.3
  • Update to Phoenix 1.6
    • Deletes package.json and unnecessary node.js dependencies! 🎉
  • Update underlying dependency elixir_auth_github to 1.5.0 📦

Here's one we made earlier: dwyl/elixir-auth-github-demo#18

The demo app is currently working on heroku using "old" version: https://elixir-auth-google-demo.herokuapp.com/
image
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! chore a tedious but necessary task often paying technical debt T25m Time Estimate 25 Minutes labels Oct 5, 2021
@nelsonic nelsonic self-assigned this Oct 5, 2021
@nelsonic nelsonic mentioned this issue Oct 5, 2021
Merged
1 task
nelsonic added a commit that referenced this issue Oct 5, 2021
@nelsonic
fix heex templates fixes #6
1c3a350
@nelsonic
Copy link
Member Author

nelsonic commented Oct 5, 2021

PR: #7 assigned to @SimonLab

@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Oct 5, 2021
@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Oct 5, 2021
@nelsonic nelsonic closed this as completed Oct 6, 2021
SimonLab added a commit that referenced this issue Oct 6, 2021
@SimonLab
Merge pull request #7 from dwyl/update-to-latest-phoenix-issue-#6
7d09a41 
Update to Phoenix 1.6 and Elixir 1.12.3 fixes #6
@SimonLab SimonLab removed their assignment Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab