-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MIXUP page #625
Add MIXUP page #625
Conversation
Deploying dwhdelft-nl with Cloudflare Pages
|
Deploying outsite-nl with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two random initial comments, will take a more in-depth look later :)
but at first sight: looks cool! Good reuse of existing things!
Fix linked events async data issues
shared/assets/images/mixup_logo.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is not a shared asset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured it might be at a certain point. Such as in the MoreDWH component?
Co-authored-by: Casper Boone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some things I think could be improved, but that'd work for a next iteration as well. Looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a photo of the actual drag folks would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! I believe Colin & Musy were working on creating some new pictures that he will send at a certain point. I'll update it for v2!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as with the drag, a photo would fit better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a great picture for a highlight, it looks like werklicht and pre-Owen-cleaning-floors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A highlight also shouldn't be a poster I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be nice to have this use the format of the dance nights | parties | drag shows | events segment instead of the icons... and maybe have one or the other depending on whether the sheet is filled? With upcoming events, the general overview, the highlights and the Instagram we have a lot of event-like boxes summing up what we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I think it will a bit more tricky to import new images for new events every time, but I'll take a look to see what I can do. I also agree that it might be a bit much, though there isn't a whole lot of other content, so I'll discuss with MIXUP what they might want!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect for a great first public version <3 Would love to see some changes as we have put in the discussions but as there are no breaking items it is perfect 👍
No description provided.