Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIXUP page #625

Merged
merged 45 commits into from
Dec 18, 2024
Merged

Add MIXUP page #625

merged 45 commits into from
Dec 18, 2024

Conversation

thomcsmits
Copy link
Member

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying dwhdelft-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4c5641
Status: ✅  Deploy successful!
Preview URL: https://b6812e2a.dwhdelft-nl-u1a.pages.dev
Branch Preview URL: https://thomcsmits-mixup2.dwhdelft-nl-u1a.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying outsite-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4c5641
Status: ✅  Deploy successful!
Preview URL: https://d2a01cc8.dwhdelft-nl.pages.dev
Branch Preview URL: https://thomcsmits-mixup2.dwhdelft-nl.pages.dev

View logs

@thomcsmits thomcsmits marked this pull request as ready for review November 20, 2024 17:02
Copy link
Member

@casperboone casperboone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two random initial comments, will take a more in-depth look later :)

but at first sight: looks cool! Good reuse of existing things!

dwhdelft.nl/assets/images/photos/mixup/icons/bar.png Outdated Show resolved Hide resolved
dwhdelft.nl/pages/mixup.vue Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not a shared asset

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it might be at a certain point. Such as in the MoreDWH component?

dwhdelft.nl/assets/images/photos/mixup/icons/tasting.svg Outdated Show resolved Hide resolved
dwhdelft.nl/components/pages/mixup/LinkedEvents.vue Outdated Show resolved Hide resolved
dwhdelft.nl/pages/mixup.vue Show resolved Hide resolved
dwhdelft.nl/pages/mixup.vue Show resolved Hide resolved
dwhdelft.nl/pages/mixup.vue Show resolved Hide resolved
Copy link
Contributor

@ARBaart ARBaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some things I think could be improved, but that'd work for a next iteration as well. Looks good otherwise!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a photo of the actual drag folks would be better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! I believe Colin & Musy were working on creating some new pictures that he will send at a certain point. I'll update it for v2!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with the drag, a photo would fit better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a great picture for a highlight, it looks like werklicht and pre-Owen-cleaning-floors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A highlight also shouldn't be a poster I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be nice to have this use the format of the dance nights | parties | drag shows | events segment instead of the icons... and maybe have one or the other depending on whether the sheet is filled? With upcoming events, the general overview, the highlights and the Instagram we have a lot of event-like boxes summing up what we do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. I think it will a bit more tricky to import new images for new events every time, but I'll take a look to see what I can do. I also agree that it might be a bit much, though there isn't a whole lot of other content, so I'll discuss with MIXUP what they might want!

Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect for a great first public version <3 Would love to see some changes as we have put in the discussions but as there are no breaking items it is perfect 👍

@thomcsmits thomcsmits merged commit 60a084c into main Dec 18, 2024
3 checks passed
@thomcsmits thomcsmits mentioned this pull request Dec 18, 2024
@ilgazer ilgazer linked an issue Jan 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIXUP enhancements
4 participants