Fix Barbuddy Bug #652
Open
Fix Barbuddy Bug #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying outsite-nl with
|
| Latest commit: |
e5f5b4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ab41f9f.dwhdelft-nl.pages.dev |
| Branch Preview URL: | https://fix-barbuddy-bug.dwhdelft-nl.pages.dev |
Deploying dwhdelft-nl with
|
| Latest commit: |
e5f5b4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a4430d4.dwhdelft-nl-u1a.pages.dev |
| Branch Preview URL: | https://fix-barbuddy-bug.dwhdelft-nl-u1a.pages.dev |
ilgazer
force-pushed
the
fix-barbuddy-bug
branch
from
5224e40 to
e5f5b4e
Compare
casperboone
requested changes
Jan 15, 2025
Comment on lines
+46
to
+48
| v-for="buddy in barBuddies.filter( | ||
| (b) => b.sites.indexOf(runtimeConfig.public.domain) !== -1 && b[$i18n.locale] | ||
| )" |
There was a problem hiding this comment.
Suggested change
| v-for="buddy in barBuddies.filter( | |
| (b) => b.sites.indexOf(runtimeConfig.public.domain) !== -1 && b[$i18n.locale] | |
| )" | |
| v-for="buddy in barBuddies.filter( | |
| (b) => b.sites.includes(runtimeConfig.public.domain) && b[$i18n.locale] | |
| )" |
There was a problem hiding this comment.
Also, especially since we're using this twice, but also because it's quite a bit of logic for the template, I think it's a good idea to make this a computed property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595, the correct barbuddies are now loaded when the language is changed from the navbar.