From d4d652e758ca56b8c337b9ebfa136d83c29e9b9c Mon Sep 17 00:00:00 2001
From: maalni <mail@koenig-alexander.dev>
Date: Wed, 5 Jun 2024 10:32:50 +0200
Subject: [PATCH 1/2] chore: update char and weapon keys (#248)

---
 src/lib/types/keys/CharacterKey.ts | 3 +++
 src/lib/types/keys/WeaponKey.ts    | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/lib/types/keys/CharacterKey.ts b/src/lib/types/keys/CharacterKey.ts
index 2536ff18..cc2f634e 100644
--- a/src/lib/types/keys/CharacterKey.ts
+++ b/src/lib/types/keys/CharacterKey.ts
@@ -14,6 +14,7 @@ export const characterKeyList = [
 	'Chevreuse',
 	'Chiori',
 	'Chongyun',
+	'Clorinde',
 	'Collei',
 	'Cyno',
 	'Dehya',
@@ -58,8 +59,10 @@ export const characterKeyList = [
 	'Rosaria', // Rosaria
 	'SangonomiyaKokomi', // Sangonomiya Kokomi
 	'Sayu', // Sayu
+	'Sethos',
 	'Shenhe', // Shenhe
 	'ShikanoinHeizou', // Shikanoin Heizou
+	'Sigewinne',
 	'Sucrose', // Sucrose
 	'Tartaglia', // Tartaglia
 	'Thoma', // Thoma
diff --git a/src/lib/types/keys/WeaponKey.ts b/src/lib/types/keys/WeaponKey.ts
index d43cc6e4..03adc507 100644
--- a/src/lib/types/keys/WeaponKey.ts
+++ b/src/lib/types/keys/WeaponKey.ts
@@ -1,5 +1,6 @@
 const weaponKeyList = [
 	'Unknown3Star',
+	'Absolution',
 	'AThousandFloatingDreams',
 	'Akuoumaru',
 	'AlleyHunter',
@@ -21,6 +22,7 @@ const weaponKeyList = [
 	'BloodtaintedGreatsword',
 	'CalamityQueller',
 	'CashflowSupervision',
+	'Cloudforged',
 	'CinnabarSpindle',
 	'CompoundBow',
 	'CoolSteel',
@@ -127,6 +129,7 @@ const weaponKeyList = [
 	'SeasonedHuntersBow',
 	'SerpentSpine',
 	'SharpshootersOath',
+	'SilvershowerHeartstrings',
 	'SilverSword',
 	'SkyriderGreatsword',
 	'SkyriderSword',

From 91b14cfd1b0ecec1cb10b4996847cb6e58f3f043 Mon Sep 17 00:00:00 2001
From: maalni <mail@koenig-alexander.dev>
Date: Wed, 5 Jun 2024 10:47:28 +0200
Subject: [PATCH 2/2] fix: build char page based on index instead of type array
 (#249)

* fix: build char page based on index instead of type array

* chore: remove unnecessary button
---
 src/routes/characters/+page.svelte | 43 +++++++++++-------------------
 1 file changed, 15 insertions(+), 28 deletions(-)

diff --git a/src/routes/characters/+page.svelte b/src/routes/characters/+page.svelte
index 813a7f3e..b979adb8 100644
--- a/src/routes/characters/+page.svelte
+++ b/src/routes/characters/+page.svelte
@@ -1,25 +1,20 @@
 <script lang="ts">
 	import IconButton from '$lib/components/ui/icon-button/IconButton.svelte';
-	import { mdiFilterOutline, mdiSort, mdiViewGrid, mdiViewList } from '@mdi/js';
+	import { mdiFilterOutline, mdiSort } from '@mdi/js';
 	import CharCard from '$lib/components/ui/card/CharCard.svelte';
 	import Searchbar from '$lib/components/ui/searchbar/Searchbar.svelte';
 	import S3Service from '$lib/services/s3';
-	import {
-		type CharacterKey,
-		characterKeyList,
-		isCharacterKey
-	} from '$lib/types/keys/CharacterKey';
 	import DefaultLayout from '$lib/components/layout/DefaultLayout.svelte';
 	import type { WeaponTypes } from '$lib/types/weapon';
 	import type { Elements } from '$lib/types/elements';
 	import { dataIndexStore } from '$lib/store/index_store';
 	import i18n from '$lib/services/i18n';
 	import { userProfile } from '$lib/store/user_profile';
+	import { get } from 'svelte/store';
 
-	let view = true;
 	let charData: {
 		link: string;
-		name: CharacterKey;
+		name: string;
 		element: Elements;
 		weapon: WeaponTypes;
 		img: string;
@@ -29,26 +24,19 @@
 
 	const userCharData = $userProfile.characters;
 
-	charData = characterKeyList
-		.filter((key) => isCharacterKey(key))
-		.map((key: CharacterKey) => {
-			const index = $dataIndexStore.character[key];
+	charData = Object.keys($dataIndexStore.character).map((key) => {
+		const index = get(dataIndexStore).character[key];
 
-			return {
-				obtained:
-					userCharData !== undefined ? Object.keys(userCharData).includes(key) : false,
-				link: '/characters/' + key,
-				name: index !== undefined ? index.name : key,
-				element: 'geo',
-				weapon: 'bow',
-				img: S3Service.getCharacter(key).icon,
-				rarity: index !== undefined ? index.rarity : 0
-			};
-		});
-
-	const toggleViewType = () => {
-		view = !view;
-	};
+		return {
+			obtained: userCharData !== undefined ? Object.keys(userCharData).includes(key) : false,
+			link: '/characters/' + key,
+			name: index.name,
+			element: 'geo',
+			weapon: 'bow',
+			img: S3Service.getCharacter(key).icon,
+			rarity: index.rarity
+		};
+	});
 </script>
 
 <DefaultLayout title={$i18n.t('characters.overview.title')}>
@@ -56,7 +44,6 @@
 		<Searchbar searchGroup="Characters" searchableDataList={charData} />
 		<IconButton icon={mdiSort}>{$i18n.t('action.sort_by')}</IconButton>
 		<IconButton icon={mdiFilterOutline}>{$i18n.t('action.filter_by')}</IconButton>
-		<IconButton icon={view ? mdiViewList : mdiViewGrid} on:click={toggleViewType} />
 	</svelte:fragment>
 	<div class="flex flex-wrap gap-4 justify-center">
 		{#each charData as character}