Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Native Context Menu #4

Open
durasj opened this issue Aug 23, 2018 · 0 comments
Open

Use Native Context Menu #4

durasj opened this issue Aug 23, 2018 · 0 comments

Comments

@durasj
Copy link
Owner

durasj commented Aug 23, 2018

Is your feature request related to a problem? Please describe.
@captbaritone proposed:

I wonder if we should expose some way for Webamp Desktop to use Electrons context menus instead of the fake ones that I made.

Describe the solution you'd like
We'll use Menu API from Electron to add the context menu via some new API. Idea for implementation from @captbaritone is

Probably the best thing to do would be for me to transition to using an internal API that matched the Electron API. Then I could just expect you to pass me a function that accepts a menu template and renders it.

Describe alternatives you've considered
I could receive an array of options and attach some callbacks for open/close but that seems a bit more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant